Merge branch 'devel'

cmd/backend/atom.go

@@ -8,8 +8,6 @@ import (
 	"git.streifling.com/jason/atom"
 )
 
-type Feed struct{ *atom.Feed }
-
 func GenerateAtomFeed(c *Config, db *DB) (*string, error) {
 	feed := atom.NewFeed(c.Title)
 	feed.ID = atom.NewID("urn:feed:1")
@@ -32,12 +30,25 @@ func GenerateAtomFeed(c *Config, db *DB) (*string, error) {
 		}
 		entry := atom.NewEntry(articleTitle)
 		entry.ID = atom.NewID(fmt.Sprint("urn:entry:", article.ID))
-		entry.Content = atom.NewContent(atom.OutOfLine, "text/hmtl", article.ContentLink)
 		entry.Published = atom.NewDate(article.Created)
 
+		if article.AutoGenerated {
+			entry.Content = atom.NewContent(atom.InlineText, "text", "")
+		} else {
+			entry.Content = atom.NewContent(atom.OutOfLine, "text/hmtl", article.ContentLink)
+
+			articleSummary, err := ConvertToPlain(article.Summary)
+			if err != nil {
+				return nil, fmt.Errorf("error converting description to plain text for Atom feed: %v", err)
+			}
+			entry.Summary = atom.NewText("text", articleSummary)
+		}
+
+		if len(article.BannerLink) > 0 {
 			linkID := entry.AddLink(atom.NewLink(article.BannerLink))
 			entry.Links[linkID].Rel = "enclosure"
 			entry.Links[linkID].Type = "image/webp"
+		}
 
 		user, err := db.GetUser(c, article.AuthorID)
 		if err != nil {
@@ -45,15 +56,6 @@ func GenerateAtomFeed(c *Config, db *DB) (*string, error) {
 		}
 		entry.AddAuthor(atom.NewPerson(user.FirstName + " " + user.LastName))
 
-		articleSummary, err := ConvertToPlain(article.Summary)
-		if err != nil {
-			return nil, fmt.Errorf("error converting description to plain text for Atom feed: %v", err)
-		}
-		if article.AutoGenerated {
-			articleSummary = "auto generated"
-		}
-		entry.Summary = atom.NewText("text", articleSummary)
-
 		tags, err := db.GetArticleTags(article.ID)
 		if err != nil {
 			return nil, fmt.Errorf("error getting tags for articles for Atom feed: %v", err)

cmd/backend/images.go

@@ -1,7 +1,6 @@
 package backend
 
 import (
-	"encoding/base64"
 	"fmt"
 	"image"
 	"io"
@@ -43,20 +42,3 @@ func SaveImage(src io.Reader, maxHeight, maxWidth int, path string) (string, err
 
 	return filename, nil
 }
-
-func ServeBase64Image(c *Config, filename string) (string, error) {
-	file := c.PicsDir + "/" + filename
-
-	img, err := os.Open(file)
-	if err != nil {
-		return "", fmt.Errorf("error opening file %v: %v", file, err)
-	}
-	defer img.Close()
-
-	imgBytes, err := io.ReadAll(img)
-	if err != nil {
-		return "", fmt.Errorf("error turning %v into bytes: %v", file, err)
-	}
-
-	return base64.StdEncoding.EncodeToString(imgBytes), nil
-}

cmd/frontend/articles.go

@@ -80,7 +80,7 @@ func SubmitArticle(c *b.Config, db *b.DB, s *b.CookieStore) http.HandlerFunc {
 
 		article := &b.Article{
 			Title:         r.PostFormValue("article-title"),
-			BannerLink:    r.PostFormValue("article-banner-url"),
+			BannerLink:    c.Domain + "/image/serve/" + r.PostFormValue("article-banner-url"),
 			Summary:       r.PostFormValue("article-summary"),
 			Published:     false,
 			Rejected:      false,
@@ -93,14 +93,6 @@ func SubmitArticle(c *b.Config, db *b.DB, s *b.CookieStore) http.HandlerFunc {
 			http.Error(w, "Bitte den Titel eingeben.", http.StatusBadRequest)
 			return
 		}
-		if len(article.BannerLink) == 0 {
-			http.Error(w, "Bitte ein Titelbild einfügen.", http.StatusBadRequest)
-			return
-		}
-		if len(article.Summary) == 0 {
-			http.Error(w, "Bitte die Beschreibung eingeben.", http.StatusBadRequest)
-			return
-		}
 
 		article.ID, err = db.AddArticle(article)
 		if err != nil {
@@ -181,12 +173,13 @@ func ResubmitArticle(c *b.Config, db *b.DB, s *b.CookieStore) http.HandlerFunc {
 			return
 		}
 
-		summary := r.PostFormValue("article-summary")
+		bannerLink := r.PostFormValue("article-banner-url")
-		if len(summary) == 0 {
+		if len(bannerLink) != 0 {
-			http.Error(w, "Bitte die Beschreibung eingeben.", http.StatusBadRequest)
+			bannerLink = c.Domain + "/image/serve/" + bannerLink
-			return
 		}
 
+		summary := r.PostFormValue("article-summary")
+
 		content := r.PostFormValue("article-content")
 		if len(content) == 0 {
 			http.Error(w, "Bitte den Artikel eingeben.", http.StatusBadRequest)
@@ -202,6 +195,7 @@ func ResubmitArticle(c *b.Config, db *b.DB, s *b.CookieStore) http.HandlerFunc {
 
 		if err = db.UpdateAttributes(
 			&b.Attribute{Table: "articles", ID: id, AttName: "title", Value: title},
+			&b.Attribute{Table: "articles", ID: id, AttName: "banner_link", Value: bannerLink},
 			&b.Attribute{Table: "articles", ID: id, AttName: "summary", Value: summary},
 			&b.Attribute{Table: "articles", ID: id, AttName: "rejected", Value: false},
 			&b.Attribute{Table: "articles", ID: id, AttName: "is_in_issue", Value: r.PostFormValue("issue") == "on"},
@@ -347,13 +341,7 @@ func ReviewRejectedArticle(c *b.Config, db *b.DB, s *b.CookieStore) http.Handler
 		}
 
 		imgURL := strings.Split(data.Article.BannerLink, "/")
-		imgFileName := imgURL[len(imgURL)-1]
+		data.BannerImage = imgURL[len(imgURL)-1]
-		data.BannerImage, err = b.ServeBase64Image(c, imgFileName)
-		if err != nil {
-			log.Println(err)
-			http.Error(w, err.Error(), http.StatusInternalServerError)
-			return
-		}
 
 		articleAbsName := fmt.Sprint(c.ArticleDir, "/", data.Article.ID, ".md")
 		content, err := os.ReadFile(articleAbsName)
@@ -624,13 +612,7 @@ func ReviewArticle(c *b.Config, db *b.DB, s *b.CookieStore, action, title, butto
 		}
 
 		imgURL := strings.Split(article.BannerLink, "/")
-		imgFileName := imgURL[len(imgURL)-1]
+		data.BannerImage = imgURL[len(imgURL)-1]
-		data.BannerImage, err = b.ServeBase64Image(c, imgFileName)
-		if err != nil {
-			log.Println(err)
-			http.Error(w, err.Error(), http.StatusInternalServerError)
-			return
-		}
 
 		data.Article.Summary, err = b.ConvertToPlain(article.Summary)
 		if err != nil {
@@ -807,13 +789,7 @@ func EditArticle(c *b.Config, db *b.DB, s *b.CookieStore) http.HandlerFunc {
 		}
 
 		imgURL := strings.Split(data.Article.BannerLink, "/")
-		imgFileName := imgURL[len(imgURL)-1]
+		data.BannerImage = imgURL[len(imgURL)-1]
-		data.BannerImage, err = b.ServeBase64Image(c, imgFileName)
-		if err != nil {
-			log.Println(err)
-			http.Error(w, err.Error(), http.StatusInternalServerError)
-			return
-		}
 
 		content, err := os.ReadFile(fmt.Sprint(c.ArticleDir, "/", data.Article.ID, ".md"))
 		if err != nil {

cmd/frontend/images.go

@@ -5,6 +5,7 @@ import (
 	"html/template"
 	"log"
 	"net/http"
+	"path/filepath"
 
 	b "streifling.com/jason/cpolis/cmd/backend"
 )
@@ -69,20 +70,8 @@ func UploadBanner(c *b.Config, s *b.CookieStore, fileKey, htmlFile, htmlTemplate
 			return
 		}
 
-		base64Img, err := b.ServeBase64Image(c, filename)
+		data := new(struct{ BannerImage string })
-		if err != nil {
+		data.BannerImage = filename
-			log.Println(err)
-			http.Error(w, err.Error(), http.StatusInternalServerError)
-			return
-		}
-
-		data := new(struct {
-			BannerImage string
-			URL         string
-		})
-
-		data.BannerImage = base64Img
-		data.URL = c.Domain + "/image/serve/" + filename
 
 		tmpl, err := template.ParseFiles(c.WebDir + "/templates/" + htmlFile)
 		if err = template.Must(tmpl, err).ExecuteTemplate(w, htmlTemplate, data); err != nil {
@@ -92,3 +81,22 @@ func UploadBanner(c *b.Config, s *b.CookieStore, fileKey, htmlFile, htmlTemplate
 		}
 	}
 }
+
+func ServeImage(c *b.Config, s *b.CookieStore) http.HandlerFunc {
+	return func(w http.ResponseWriter, r *http.Request) {
+		if _, err := getSession(w, r, c, s); err != nil {
+			log.Println(err)
+			http.Error(w, err.Error(), http.StatusInternalServerError)
+			return
+		}
+
+		absFilepath, err := filepath.Abs(c.PicsDir)
+		if err != nil {
+			log.Println(err)
+			http.Error(w, err.Error(), http.StatusInternalServerError)
+			return
+		}
+
+		http.ServeFile(w, r, absFilepath+"/"+r.PathValue("img"))
+	}
+}

cmd/frontend/issues.go

@@ -41,10 +41,6 @@ func PublishLatestIssue(c *b.Config, db *b.DB, s *b.CookieStore) http.HandlerFun
 			http.Error(w, "Bitte den Titel eingeben.", http.StatusBadRequest)
 			return
 		}
-		if len(article.BannerLink) == 0 {
-			http.Error(w, "Bitte ein Titelbild einfügen.", http.StatusBadRequest)
-			return
-		}
 
 		article.ID, err = db.AddArticle(article)
 		if err != nil {

cmd/main.go

@@ -68,6 +68,7 @@ func main() {
 	mux.HandleFunc("GET /article/write", f.WriteArticle(config, db, store))
 	mux.HandleFunc("GET /atom/serve", c.ServeAtomFeed(config))
 	mux.HandleFunc("GET /hub", f.ShowHub(config, db, store))
+	mux.HandleFunc("GET /image/{img}", f.ServeImage(config, store))
 	mux.HandleFunc("GET /image/serve/{pic}", c.ServeImage(config))
 	mux.HandleFunc("GET /issue/this", f.ShowCurrentIssue(config, db, store))
 	mux.HandleFunc("GET /logout", f.Logout(config, store))

web/templates/editor.html

@@ -3,10 +3,7 @@
 
 <form id="edit-area" hx-encoding="multipart/form-data">
     <div class="flex flex-col gap-y-1">
-        <div class="w-full" id="article-banner-container">
+        {{template "article-banner-template" .}}
-            <img src="data:image/webp;base64,{{.BannerImage}}" alt="Banner Image">
-            <input id="article-banner-url" name="article-banner-url" type="hidden" value="{{.Article.BannerLink}}" />
-        </div>
 
         <div class="grid grid-cols-2 gap-4 items-center">
             <div class="flex flex-col">
@@ -17,7 +14,7 @@
             <div class="grid grid-cols-1 items-center">
                 <label class="btn text-center" for="article-banner">Titelbild</label>
                 <input class="hidden" id="article-banner" name="article-banner" type="file" required
-                    hx-post="/article/upload-banner" hx-target="#article-banner-container" />
+                    hx-post="/article/upload-banner" hx-swap="outerHTML" hx-target="#article-banner-container" />
             </div>
         </div>
     </div>
@@ -92,8 +89,8 @@
 {{end}}
 
 {{define "article-banner-template"}}
-<div class="w-full" id="article-banner-container">
+<div id="article-banner-container">
-    <img src="data:image/webp;base64,{{.BannerImage}}" alt="Banner Image">
+    <img src="/image/{{.BannerImage}}" alt="">
-    <input id="article-banner-url" name="article-banner-url" type="hidden" value="{{.URL}}" />
+    <input id="article-banner-url" name="article-banner-url" type="hidden" value="{{.BannerImage}}" />
 </div>
 {{end}}

web/templates/review-article.html

@@ -3,7 +3,7 @@
 
 <div>
     <div class="w-full" id="article-banner-container">
-        <img src="data:image/webp;base64,{{.BannerImage}}" alt="Banner Image">
+        <img src="/image/{{.BannerImage}}" alt="Banner Image">
     </div>
 
     <span>Titel</span>